Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )
Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 1: Code-Review-1 (6 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/471/comment/7cbe21a6_5ded543e : PS1, Line 560: "test_ssl" Those are sorted alphabetically http://gerrit.openvpn.net/c/openvpn/+/471/comment/fb6707f8_9e4c3991 : PS1, Line 675: target_sources(test_ssl PRIVATE also sorted alphabetically File tests/unit_tests/openvpn/mock_management.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/013fb9b0_9685277c : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. <open...@foxcrypto.com> Copy & paste error? Or intentional? File tests/unit_tests/openvpn/mock_ssl_dependencies.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/e183659b_a49b0182 : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. <open...@foxcrypto.com> intentional? http://gerrit.openvpn.net/c/openvpn/+/471/comment/8366d424_83a92832 : PS1, Line 24: /* Minimal set of mocked management function/globals to get unit tests to "management" is probably copy&paste File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/c8cca67b_59a239d1 : PS1, Line 8: * Copyright (C) 2016-2021 Fox Crypto B.V. <open...@foxcrypto.com> probably not intentional -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Fri, 08 Dec 2023 16:40:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
