Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )
Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File tests/unit_tests/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/471/comment/0c7d5a64_4d9a9d5c : PS2, Line 86: $(top_srcdir)/src/openvpn/xkey_provider.c \ indent File tests/unit_tests/openvpn/mock_management.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/1c9c81df_b412d262 : PS2, Line 49: (void) man; inconsistent (void), used it in one function, but not the other File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/f87f0957_64554c69 : PS2, Line 47: /* Mock function to be allowed to include win32.c which is required for You originally created win32-util.c for the purpose of UT (see commit 5a571fb0f68ce6961cddfa495af2cedf3ee0e216). Maybe just move the win_get_tempdir to that? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 12 Dec 2023 13:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
