Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )
Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 1: (6 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/471/comment/0db70bef_074e855b : PS1, Line 560: "test_ssl" > Those are sorted alphabetically Done http://gerrit.openvpn.net/c/openvpn/+/471/comment/e741cdb3_5a0aaaff : PS1, Line 675: target_sources(test_ssl PRIVATE > also sorted alphabetically I sorted them like the other ones that include mock files and have the test/mock files first and not strictly alphabetical which would have put them at the end. File tests/unit_tests/openvpn/mock_management.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/5b10dbd9_9e007792 : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. <open...@foxcrypto.com> > Copy & paste error? Or intentional? Done File tests/unit_tests/openvpn/mock_ssl_dependencies.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/979d7c62_638080d7 : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. <open...@foxcrypto.com> > intentional? Done http://gerrit.openvpn.net/c/openvpn/+/471/comment/96b5a578_3c274b81 : PS1, Line 24: /* Minimal set of mocked management function/globals to get unit tests to > "management" is probably copy&paste Done File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/8b19f7d6_6a5c48d6 : PS1, Line 8: * Copyright (C) 2016-2021 Fox Crypto B.V. <open...@foxcrypto.com> > probably not intentional Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 11 Dec 2023 13:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
