Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )
Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: Something is weird here. The unit test passes on "unixy" platforms, and msbuild in GHA has no complaints (but might not build it either). mingw+cmake fails with an error related to pulling in wfp ``` [115/296] Linking C executable Debug/test_pkt.exe 364 [116/296] Building C object CMakeFiles/test_ssl.dir/Debug/src/openvpn/block_dns.c.obj 365 FAILED: CMakeFiles/test_ssl.dir/Debug/src/openvpn/block_dns.c.obj ``` while building autoconf-based mingw compiles the bits fine, and fails linking ``` CC ../../../src/openvpn/ssl_testdriver-xkey_helper.o CC ../../../src/openvpn/ssl_testdriver-ssl_util.o CC ../../../src/openvpn/ssl_testdriver-base64.o CC ../../../src/openvpn/ssl_testdriver-cryptoapi.o CCLD ssl_testdriver.exe /usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi.o:cryptoapi.c:(.text+0x27c): undefined reference to `NCryptFreeObject@4' /usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi.o:cryptoapi.c:(.text+0x2b2): undefined reference to `_imp__CertFreeCertificateContext@4' ... /usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi.o:cryptoapi.c:(.text+0xf9a): undefined reference to `tls_libctx' ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 16 Jan 2024 11:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
