Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( )

Change subject: Implement support for larger packet counter sizes

Patch Set 3: Code-Review-2



DCO check is broken. Otherwise mostly documentation/comment nitpicks.

File src/openvpn/crypto.h: :
PS3, Line 292:      * big ending number in the wire format.

File src/openvpn/crypto.c: :
PS3, Line 393:     /* Combine IV from explicit part from packet and implicit 
part from context,
End on ".", not "," :
PS3, Line 394:      * the length of the implicit length is initialised when the 
implicit is
That sentence is very unwieldy. Maybe: "implicit_iv and implicit_iv_len are 
initialised in init_key_contexts together with the keys".

File src/openvpn/dco.h: :
PS3, Line 253:  * Return if the dco implementation supports the new protocol 
features of
"if" -> "whether"

File src/openvpn/init.c: :
PS3, Line 3308:         to.data_v3_features_supported = false;
I think you mean "to.data_v3_features_supported = dco_supports_data_v3(c)" ?

File src/openvpn/ssl_ncp.c: :
PS2, Line 433:     if (session->opt->data_v3_features_supported && 
(iv_proto_peer & IV_PROTO_DATA_V3))
> The thing here is that I didn't want to introduce two IV_PROTO flags and so 
> the 2nd patch for the tw […]

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2
Gerrit-Change-Number: 507
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <>
Gerrit-Reviewer: flichtenheld <>
Gerrit-CC: openvpn-devel <>
Gerrit-Attention: plaisthos <>
Gerrit-Comment-Date: Mon, 18 Mar 2024 15:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <>
Comment-In-Reply-To: flichtenheld <>
Gerrit-MessageType: comment
Openvpn-devel mailing list

Reply via email to