Attention is currently required from: stipa.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/507?usp=email )

Change subject: Implement support for larger packet counter sizes
......................................................................


Patch Set 6:

(3 comments)

File src/openvpn/crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/507/comment/339be4fb_e4a7dcd8 :
PS6, Line 364: openvpn_decrypt_aead(struct buffer *buf, struct buffer work,
> Is it so that for DATA_V1: […]
yes. But that has been always the case.


File src/openvpn/ssl_common.h:

http://gerrit.openvpn.net/c/openvpn/+/507/comment/ed094001_4358b379 :
PS6, Line 314:     bool disable_occ;
> this looks like an unrelated change
Yes. But I don't think it warranted an extra commit and I modify that part 
anyway.


http://gerrit.openvpn.net/c/openvpn/+/507/comment/a566bc93_6c0e149b :
PS6, Line 493:     int limit_next;             /* used for traffic shaping on 
the control channel */
> ditto
same, just removing an unused variable



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2
Gerrit-Change-Number: 507
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 12:12:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipa...@gmail.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to