Attention is currently required from: plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email )
Change subject: Implement support for larger packet counter sizes ...................................................................... Patch Set 6: Code-Review+1 (6 comments) Patchset: PS6: A few minor comments, otherwise LGTM File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/057e647e_235cce26 : PS6, Line 364: openvpn_decrypt_aead(struct buffer *buf, struct buffer work, Is it so that for DATA_V1: ad_start points to packet_id and for DATA_V2: ad_start points to opcode/peer-id ? File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/68137a62_4480a3d5 : PS6, Line 2696: /* Ensure that for proto v3 is enabled fully or not at all */ Ensure that both aead_tag_end and long_pkt_id are enabled for DATA_V3 ? File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/758ca11c_70a5b728 : PS6, Line 1528: impl_iv_len = cipher_ctx_iv_length(ctx->cipher) - packet_id_size(longiv); why not move declaration of impl_iv_len here? File src/openvpn/ssl_common.h: http://gerrit.openvpn.net/c/openvpn/+/507/comment/e1373829_32fe9ec0 : PS6, Line 314: bool disable_occ; this looks like an unrelated change http://gerrit.openvpn.net/c/openvpn/+/507/comment/b333e775_ad0af8c2 : PS6, Line 493: int limit_next; /* used for traffic shaping on the control channel */ ditto -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2 Gerrit-Change-Number: 507 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Wed, 31 Jul 2024 14:12:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
