Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/f6e72862_6ae239a4 : PS1, Line 5472: if (!apply_pull_filter(options, line)) ``` options.c: In function ‘apply_push_options’: options.c:5472:14: error: too few arguments to function ‘apply_pull_filter’ 5472 | if (!apply_pull_filter(options, line)) | ^~~~~~~~~~~~~~~~~ In file included from options.c:66: options_util.h:34:1: note: declared here 34 | apply_pull_filter(const struct options *o, | ^~~~~~~~~~~~~~~~~ ``` http://gerrit.openvpn.net/c/openvpn/+/808/comment/09d1a5a6_ed8662d7 : PS1, Line 5618: apply_push_options(struct context *c, ``` options.c:5456:1: error: conflicting types for ‘apply_push_options’; have ‘_Bool(struct options *, struct buffer *, unsigned int, unsigned int *, struct env_set *)’ 5456 | apply_push_options(struct options *options, | ^~~~~~~~~~~~~~~~~~ In file included from ssl.h:40, from options.c:45: options.h:875:6: note: previous declaration of ‘apply_push_options’ with type ‘_Bool(struct context *, struct options *, struct buffer *, unsigned int, unsigned int *, struct env_set *, _Bool)’ 875 | bool apply_push_options(struct context *c, | ^~~~~~~~~~~~~~~~~~ ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mrbff <ma...@mandelbit.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 13:10:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
