Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 4: (7 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/808/comment/6208a664_8a387af8 : PS4, Line 812: nit: whitespace File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/4862d3bd_9b57ad9f : PS4, Line 2033: int status = do_route(&c->options, c->c1.route_list, c->c1.route_ipv6_list, nice catch! File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/93ec136c_da93606f : PS4, Line 124: check_push_update_option_flags(char **line, unsigned int *flags) Add doxygen what does this function do. http://gerrit.openvpn.net/c/openvpn/+/808/comment/cacb7fd2_2e6844f7 : PS4, Line 138: if (str[1]) below 8 lines are duplicated 3 times. Maybe define a macro and reuse it, and later undefine? Like #define ADVANCE_OR_FAIL(ptr) \ do { \ if (!(ptr)[1]) \ return false; \ c = *(++(ptr)); \ } while (0) http://gerrit.openvpn.net/c/openvpn/+/808/comment/fc0ee113_1823490a : PS4, Line 160: if (c == '-' && !(*flags & PUSH_OPT_TO_REMOVE)) you could remove the "c == '-'" check here and move this whole block under the "if" condition above http://gerrit.openvpn.net/c/openvpn/+/808/comment/76877514_402d6e34 : PS4, Line 221: apply_pull_filter(const struct options *o, char *line, bool is_update, unsigned int *push_update_option_flags) Let's move doxygen to the header. File src/openvpn/push.h: http://gerrit.openvpn.net/c/openvpn/+/808/comment/811984a2_89dbae3b : PS4, Line 47: int process_incoming_push_update(struct context *c, Doxygen -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mrbff <ma...@mandelbit.com> Gerrit-Comment-Date: Wed, 27 Nov 2024 11:41:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
