Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 5: (7 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/808/comment/8f5a6f36_8362c01a : PS4, Line 812: > nit: whitespace Done File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/bd8dd262_1158ed00 : PS4, Line 2033: int status = do_route(&c->options, c->c1.route_list, c->c1.route_ipv6_list, > nice catch! tnx! File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/f8c35b78_8f40c7a2 : PS4, Line 124: check_push_update_option_flags(char **line, unsigned int *flags) > Add doxygen what does this function do. Done http://gerrit.openvpn.net/c/openvpn/+/808/comment/a0c306fd_1444ca21 : PS4, Line 138: if (str[1]) > below 8 lines are duplicated 3 times. Maybe define a macro and reuse it, and > later undefine? Like […] Clever, i like it, I tried but when the compiler optimizes it, the code gets skipped. Anyway, i simplified and now i use it just 2 times and with a slightly different condition so i hope is good enough http://gerrit.openvpn.net/c/openvpn/+/808/comment/a517e1a9_3a38d88f : PS4, Line 160: if (c == '-' && !(*flags & PUSH_OPT_TO_REMOVE)) > you could remove the "c == '-'" check here and move this whole block under > the "if" condition above I'm not entirely sure that's what you meant but I simplified http://gerrit.openvpn.net/c/openvpn/+/808/comment/ada8cdcc_81c709fb : PS4, Line 221: apply_pull_filter(const struct options *o, char *line, bool is_update, unsigned int *push_update_option_flags) > Let's move doxygen to the header. Done File src/openvpn/push.h: http://gerrit.openvpn.net/c/openvpn/+/808/comment/276f3131_7f2768f9 : PS4, Line 47: int process_incoming_push_update(struct context *c, > Doxygen Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 5 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Thu, 28 Nov 2024 15:21:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
