Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 10: Code-Review-1 (4 comments) Patchset: PS10: This works, but I find the `local_list` structure in need of improvement. File src/openvpn/options.h: http://gerrit.openvpn.net/c/openvpn/+/436/comment/b51da7c8_0ec98e70 : PS10, Line 105: struct local_list *local_list; I do not like this data structure - having an extra indirection seems to serve no good purpose (like, it's not actually a "list"). All the other new multisocket code just has a local array, and I think we should do the same thing here - that is: `struct connection_entry { struct local_entry *local_list; int local_list_len; ... ` most of the remaining code will simplify itself (`ce->local_list->array[i]` to `ce->local_list[i]` etc.) or will not care at all (if dealing with a `le`). File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/b6ab664e_ab058053 : PS10, Line 2476: msg(M_USAGE, "--remote and a --local addresses are the same"); `a local address`, singular :-) (or `one of the --local addresses`) Dunno. Something grammarly correct :-) File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/fc6cd992_13935a2b : PS10, Line 421: for (int j = 0; j < ce->local_list->len; j++) is this save against "no `--local` specified at all, list not initialized"? The old code had an `if (ce->bind_local)` check here, for which I'm missing the equivalent -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 10 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Mon, 30 Dec 2024 19:04:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
