Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 10: (1 comment) File src/openvpn/options.h: http://gerrit.openvpn.net/c/openvpn/+/436/comment/6b965d3f_513428fb : PS10, Line 105: struct local_list *local_list; > I do not like this data structure - having an extra indirection seems to > serve no good purpose (like […] Gianmarco dived north and south to remove this local_list container. However, he found the actual reason for having a pointer to a container here, instead of the plain array: the value of `struct local_list *` is copied over all connection entries, so that the list of locals can be shared. If we remove such container and let a `struct connection_entry` directly have a `local_list[]` member, we then need to copy this array over to every other connection entry. Hence, we use more memory and we must memcpy() the array to every `ce`. Would you agree that it may be better to keep the local_list container as it is now and avoid this complexity? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 10 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 15:21:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
