Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 11: (4 comments) Patchset: PS11: A few comments to look at, but at this point I'd say "fix the manpage and ship" ;-) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/5e7f4c84_d49c3a9f : PS11, Line 124: open a socket. As discussed on IRC, this is still a bit unclear / a leftover from earlier versions. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/87b58fcf_5e96bec6 : PS11, Line 2485: if (le->local && !ce->bind_local) I do wonder if we really need to check this for every entry in the local_list, or checking it once (`if ( ce->local_list && !ce->bind_local )`) would be sufficient... but this is not really important. http://gerrit.openvpn.net/c/openvpn/+/436/comment/9744ee88_ecea7af7 : PS11, Line 3780: options_postprocess_mutate_le(o->ce, o->ce.local_list->array[i]); I guess that this is preparations for one of the later patches? For the simple case having an extra function 420 lines further up in the code seems more complicated then necessary. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 11 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Thu, 23 Jan 2025 15:22:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
