Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
Change subject: Implement epoch key data format ...................................................................... Patch Set 12: (4 comments) Patchset: PS12: light review, spotted a few minor things File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/806/comment/28a72564_50bb6c50 : PS12, Line 38: Epoch data keys maybe make that header "epoch data keys & packet format" or so? The text describes keys and format... http://gerrit.openvpn.net/c/openvpn/+/806/comment/a96b47e7_f7937579 : PS12, Line 40: ciphers in TLS mode ciphers. This new data format has a number of= stray `=` File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/806/comment/f3bd08f7_4e5efc26 : PS12, Line 455: goto error_exit; that `goto` should not be needed? CRYPT_DROP() expands to CRYPT_ERROR_EXIT() which has the goto -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00751c42cb04e30205ba8e6584530831e0d143c5 Gerrit-Change-Number: 806 Gerrit-PatchSet: 12 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 08:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
