Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
Change subject: Implement epoch key data format
......................................................................
Patch Set 18: Code-Review-2
(2 comments)
Patchset:
PS18:
Client- and Server-side tests pass now, including NCP malicousness ("none",
"ARIA-CBC").
I do not feel comfortable giving a +2 for the crypto bits, but the rest of the
changes look good to me.
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/806/comment/6feaf7c3_3bc9619b :
PS18, Line 3040: if (ks->crypto_options.flags & CO_EPOCH_DATA_KEY_FORMAT)
if we need to do another round of this patch, it would be nice to be consistent
with all the other checks and have a comment above the `if()`
```
/* epoch approaching the 16 bit limit */
```
or so.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I00751c42cb04e30205ba8e6584530831e0d143c5
Gerrit-Change-Number: 806
Gerrit-PatchSet: 18
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 10:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
