Attention is currently required from: cron2, flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )

Change subject: Implement epoch key data format
......................................................................


Patch Set 12:

(3 comments)

File Changes.rst:

http://gerrit.openvpn.net/c/openvpn/+/806/comment/7cb2c8ce_a1734688 :
PS12, Line 38: Epoch data keys
> maybe make that header "epoch data keys & packet format" or so?  The text 
> describes keys and format. […]
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/806/comment/c262c810_6074d03e :
PS12, Line 40:     ciphers in TLS mode ciphers. This new data format has a 
number of=
> stray `=`
Acknowledged


File src/openvpn/crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/806/comment/54b550d3_c3929922 :
PS12, Line 455:         goto error_exit;
> that `goto` should not be needed?  CRYPT_DROP() expands to CRYPT_ERROR_EXIT() 
> which has the goto
Acknowledged



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I00751c42cb04e30205ba8e6584530831e0d143c5
Gerrit-Change-Number: 806
Gerrit-PatchSet: 12
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Fri, 10 Jan 2025 09:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to