Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email )
Change subject: Implement override-username ...................................................................... Patch Set 2: (16 comments) File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/21228070_1f46d719 : PS1, Line 41: client use certificates and multi-factor authentication. > "clients" Done File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/06e9abaf_d78465ff : PS1, Line 673: --override-username > At the wrong place in the document alphabetically Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/7c534346_cab10b4d : PS1, Line 674: Sets the username of a connection the specified username. This username > "to the" Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/a75a4873_d2d04eb7 : PS1, Line 675: will also be used by the by ``--auth-gen-token``. However, the overridden > Superfluous words "by the"? Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/4ad0be1f_637c94bf : PS1, Line 677: ``--client-config-dir`` and the ``--auth-user-pass-verify`` script have > This is confusing. […] Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/c9dae5be_bda55455 : PS1, Line 680: Also ``username-as-common-name`` will use the client provided username > --username-as-common-name for consistency Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/0affce0e_affb761d : PS1, Line 682: ``--override-username`` option if the option ``username-as-common-name`` > superfluous space Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/ccb79877_4bb98f83 : PS1, Line 686: the the ``--auth-gen-token`` option. It will also be pushed to the client > duplicated "the" Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/67d2ea38_226d164b : PS1, Line 687: using ``--auth-token-user``. > We should add a cross-reference to documentation for --auth-token-user Done File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/d9a3829a_99fd02a5 : PS2, Line 427: ``--override-username`` option if the option ``--username-as-common-name`` Still superfluous space after "if" File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/cd8915c7_899bfa2a : PS1, Line 2670: * @param mi > Either document it or remove stub-comment. Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/e20f62db_76f7ebd8 : PS1, Line 7850: else if (streq(p[0], "override-username") && p[1] && !p[2]) > New option should be added to usage information. Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/2240b114_582b0419 : PS1, Line 7859: * set another username might serious problems */ > missing word "cause"? Done File src/openvpn/ssl_common.h: http://gerrit.openvpn.net/c/openvpn/+/872/comment/c09f832b_cfa6e127 : PS1, Line 630: * authentication */ > "unless overridden by override-user" Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/f35c8085_0b38db04 : PS1, Line 633: /** The username that client initial used before being overrriden by > "initially" Done http://gerrit.openvpn.net/c/openvpn/+/872/comment/56ae7bc5_5d6fe748 : PS1, Line 634: * by override-user */ > duplicated "by" Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4095518d5e4447992a2974e0d7a159d79ba6b6f Gerrit-Change-Number: 872 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 20 Jan 2025 15:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
