Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email )
Change subject: Implement override-username ...................................................................... Patch Set 2: (15 comments) File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/02e764b7_6304b3bf : PS1, Line 41: client use certificates and multi-factor authentication. > "clients" Acknowledged File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/334a1a85_26710d09 : PS1, Line 673: --override-username > At the wrong place in the document alphabetically Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/89fc0d0a_8affe908 : PS1, Line 674: Sets the username of a connection the specified username. This username > "to the" Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/4ce38eba_2c5c594a : PS1, Line 675: will also be used by the by ``--auth-gen-token``. However, the overridden > Superfluous words "by the"? Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/1118b7e1_d4a82479 : PS1, Line 677: ``--client-config-dir`` and the ``--auth-user-pass-verify`` script have > This is confusing. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/61c5f531_68d4138a : PS1, Line 680: Also ``username-as-common-name`` will use the client provided username > --username-as-common-name for consistency Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/eccbce07_e521f35e : PS1, Line 682: ``--override-username`` option if the option ``username-as-common-name`` > superfluous space Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/4fcc7d05_ea20ea4c : PS1, Line 686: the the ``--auth-gen-token`` option. It will also be pushed to the client > duplicated "the" Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/f664c9a3_27d05978 : PS1, Line 687: using ``--auth-token-user``. > We should add a cross-reference to documentation for --auth-token-user Acknowledged File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/cb7d16f1_b397a081 : PS1, Line 2670: * @param mi > Either document it or remove stub-comment. Acknowledged File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/a5d879a8_b2f803e4 : PS1, Line 7850: else if (streq(p[0], "override-username") && p[1] && !p[2]) > New option should be added to usage information. I am not sure about it. This is an option that is only allow in per client specific files but since --disable is documented there, so I will do it for consistency. http://gerrit.openvpn.net/c/openvpn/+/872/comment/8bcfd0ed_260b2f18 : PS1, Line 7859: * set another username might serious problems */ > missing word "cause"? Acknowledged File src/openvpn/ssl_common.h: http://gerrit.openvpn.net/c/openvpn/+/872/comment/8970872f_44928eba : PS1, Line 630: * authentication */ > "unless overridden by override-user" Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/d732026a_e80583da : PS1, Line 633: /** The username that client initial used before being overrriden by > "initially" Acknowledged http://gerrit.openvpn.net/c/openvpn/+/872/comment/40f0c46d_fedba44c : PS1, Line 634: * by override-user */ > duplicated "by" Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4095518d5e4447992a2974e0d7a159d79ba6b6f Gerrit-Change-Number: 872 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 15:29:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
