Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/815?usp=email )
Change subject: dco-win: multipeer support
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
Patchset:
PS14:
This looks all reasonable from what I have seen. It needs to be rebased to the
current state of "multisocket" (just use today's master) because too much has
changed in the "local socket" handling - mostly "everything is an array now".
I would suggest to have an extra check `if (number of --local statements > 1) {
disable_dco(); }` and then just use `link_socket[0]` - as long as the kernel
driver doesn't support multi sockets, we do not need to bother with that in the
userland side (and multisocket isn't done yet anyway).
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia267276d61fa1425ba205f54ba6eb89021f32dba
Gerrit-Change-Number: 815
Gerrit-PatchSet: 14
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 20:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
