Attention is currently required from: flichtenheld, plaisthos, stipa.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/815?usp=email )

Change subject: dco-win: multipeer support
......................................................................


Patch Set 20: Code-Review+2

(1 comment)

File src/openvpn/socket.h:

http://gerrit.openvpn.net/c/openvpn/+/815/comment/40fb319f_4992f85a :
PS20, Line 1130:             buf_write_prepend(buf, &sa, sizeof(sa));
I *do* wonder why this is not just doing

```
buf_write_prepend(buf, &to->dest.addr.in4, sizeof(sockaddr_in);
```

... but it works as it is, and I want #815 done...



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia267276d61fa1425ba205f54ba6eb89021f32dba
Gerrit-Change-Number: 815
Gerrit-PatchSet: 20
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Feb 2025 21:53:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to