Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email )
Change subject: dco-win: multipeer support ...................................................................... Patch Set 19: (5 comments) File src/openvpn/dco_win.c: http://gerrit.openvpn.net/c/openvpn/+/815/comment/00d94363_34c9a1fd : PS18, Line 146: OVPN_MODE m = OVPN_MODE_MP; > Yeah, this one is from the driver API. But I see the frustration. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/815/comment/33928f1a_ab08b8c6 : PS18, Line 291: if (out.ListenAddress.Addr4.sin_family == AF_INET) > The driver writes to out the local transport address of the socket after the > bind() call. […] Done http://gerrit.openvpn.net/c/openvpn/+/815/comment/f8813ec3_9bac21f1 : PS18, Line 393: { > I see. […] Done File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/815/comment/825741c8_e6fea2d1 : PS18, Line 1326: bool prepend_sa = c->options.mode == MODE_SERVER && dco_enabled(&c->options); > Actually we cannot end up here when using DCO. […] Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/815/comment/c67d8e5e_442ec891 : PS18, Line 3957: read_sockaddr_from_overlapped(io, &from->dest.addr.sa, ret); > SH could be either file descriptor (in case of non-dco link) or handle > (non-dco tun and dco link). […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia267276d61fa1425ba205f54ba6eb89021f32dba Gerrit-Change-Number: 815 Gerrit-PatchSet: 19 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 06 Feb 2025 18:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
