Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 21: Code-Review-1 (3 comments) Patchset: PS21: So, tested Gentoo and Debian. Gentoo has "no systemd" and it seems "no /sbin/resolvconf" either, so the script does "nothing, but return 1" - see the comment there. I could see Gentoo being an oddball, but Debian testing does not work either - the resolv conf says `# Generated by NetworkManager` and there is no `systemd-resolved` or `/sbin/resolvectl` either. I think this, at least, should work... now need to find a system that is a) linux and b) is using one of these things... File distro/dns-scripts/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/838/comment/4845ab0a_21384a93 : PS21, Line 27: can we `chmod +x` this here? Then it could be run from `t_client.rc` to test "what we made for this particular OS" without having to modify/copy around that file. File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/a3512cba_41c3b0c0 : PS21, Line 194: do_resolved || do_resolvconf On a system that has neither systemd nor `/sbin/resolvconf` (namely my gentoo system here), this will do nothing but "exit 1", and the caller will log ``` 2025-04-16 15:01:20 us=547785 ../distro/dns-scripts/dns-updown 2025-04-16 15:01:20 us=551358 dns up command exited with status 1 ``` which is not that helpful in figuring out what's going on. Maybe print some diagnostics from the scripts if things can not be done due to "your system is too old fashioned, go away"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 21 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Wed, 16 Apr 2025 13:58:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
