Attention is currently required from: cron2, flichtenheld, plaisthos.

d12fk has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )

Change subject: dns: apply settings via script on unixoid systems
......................................................................


Patch Set 15:

(3 comments)

File CMakeLists.txt:

http://gerrit.openvpn.net/c/openvpn/+/838/comment/46a4965c_d67b6a1d :
PS15, Line 582:
> does this need some sort of magic to enable `-DENABLE_DNS_UPDOWN`?
Now you can disable the feature with ccmake or `-DENABLE_DNS_UPDOWN=ON`, just 
like the others.


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/838/comment/929d0d87_38955934 :
PS15, Line 926: #ifdef ENABLE_DNS_SCRIPT
> should that be ENABLE_DNS_UPDOWN?
Done


http://gerrit.openvpn.net/c/openvpn/+/838/comment/b0363c3c_449e72d0 :
PS15, Line 8227: #ifdef ENABLE_DNS_SCRIPT
> same here
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10
Gerrit-Change-Number: 838
Gerrit-PatchSet: 15
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 22:45:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to