Attention is currently required from: d12fk, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 15: Code-Review-1 (4 comments) Patchset: PS15: Overall it looks good, but I'm afraid the change from ENABLE_DNS_SCRIPT to ENABLE_DNS_UPDOWN broke options.c File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/838/comment/4b69602a_38fa67d4 : PS15, Line 582: does this need some sort of magic to enable `-DENABLE_DNS_UPDOWN`? File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/f473ebac_d6d18ad0 : PS15, Line 926: #ifdef ENABLE_DNS_SCRIPT should that be ENABLE_DNS_UPDOWN? http://gerrit.openvpn.net/c/openvpn/+/838/comment/de0f1212_6e2780f2 : PS15, Line 8227: #ifdef ENABLE_DNS_SCRIPT same here -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 15 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Wed, 19 Mar 2025 14:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
