Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )
Change subject: Install host routes for ifconfig-push routes when DCO is enabled ...................................................................... Patch Set 8: Code-Review-2 (5 comments) Patchset: PS8: this got broken during review / respin... conceptually I have nothing to complain, but the MR_ONLINK_ADDR vs. MR_ONLINK_DCO_ADDR needs to be fixed. Admittedly I do not understand why it compiles at all (!?)... ``` $ git grep MR_ONLINK src/openvpn/dco.c: if (addr->type & MR_ONLINK_DCO_ADDR) src/openvpn/dco.c: if (addr->type & MR_ONLINK_ADDR) src/openvpn/dco.c: if (addr->type & MR_ONLINK_ADDR) src/openvpn/mroute.h:#define MR_ONLINK_DCO_ADDR 64 src/openvpn/multi.c: addr.type |= MR_ONLINK_DCO_ADDR; src/openvpn/multi.c: addr.type |= MR_ONLINK_DCO_ADDR; ``` so MR_ONLINK_ADDR is referenced, but not defined anywhere - and it still compiles. Huh. File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/785dfadb_41bb07c6?usp=email : PS8, Line 686: This got broken in patch iterations - initially everything was `MR_ONLINK_ADDR` and then the define got changed to `MR_ONLINK_DCO_ADDR` but the "not win32" platform was not adjusted? http://gerrit.openvpn.net/c/openvpn/+/1192/comment/c26431d1_ead0937a?usp=email : PS8, Line 700: if (addr->type & MR_ONLINK_ADDR) _DCO_ http://gerrit.openvpn.net/c/openvpn/+/1192/comment/b9ffbe40_0e0e1234?usp=email : PS8, Line 745: } this looks wrong. The !not WIN32 code calls `dco_win_`? http://gerrit.openvpn.net/c/openvpn/+/1192/comment/6e19a3ae_10206ebe?usp=email : PS8, Line 771: } This is asymmetric to IPv4 - I guess this is from early tests, and the `dco_win_del...()` think needs to go out? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff Gerrit-Change-Number: 1192 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Sun, 12 Oct 2025 12:55:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
