Attention is currently required from: d12fk, flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes for ifconfig-push routes when DCO is enabled ...................................................................... Patch Set 11: (1 comment) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/55223ae1_ab140e86?usp=email : PS11, Line 4377: &o->push_ifconfig_ipv6_local)); Ah, here we go. This fails if there is *no* `ifconfig-ipv6-push` in the config, as then we have ``` (gdb) print o->push_ifconfig_ipv6_local $10 = {__u6_addr = {__u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}} ``` ... and that obviously does not match. >From reading the code in `dco_delete_iroutes()`, this looks as if the check >should be on `mi->context.c2.push_ifconfig_local` and not >`mi->context.options.push_ifconfig_ipv6_local`? ... later... yep, this works: ``` struct context_2 *c2 = &mi->context.c2; return (!ipv6_net_contains_host(&ifconfig_local, o->ifconfig_ipv6_netbits, &c2->push_ifconfig_ipv6_local)); ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff Gerrit-Change-Number: 1192 Gerrit-PatchSet: 11 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Sun, 19 Oct 2025 09:49:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
