Attention is currently required from: d12fk, flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes for ifconfig-push routes when DCO is enabled ...................................................................... Patch Set 13: (6 comments) Patchset: PS8: > Yeah not really sure what happend there during my rebase. […] Done Patchset: PS11: > This is not working right yet. […] Done Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/4477c2fa_904f1747?usp=email : PS4, Line 7: Install host routes with onlink scope iroutes for ifconfig-push routes > how about: […] Done http://gerrit.openvpn.net/c/openvpn/+/1192/comment/f9794219_e00d035b?usp=email : PS4, Line 10: of the configured device need to be added to the operating system to > I agree with that, but what I meant in my comment is that we "need *routes* > to be added" not IPs. […] Done http://gerrit.openvpn.net/c/openvpn/+/1192/comment/220f5023_3980d1f4?usp=email : PS4, Line 15: iroute, will not work. > should we add "because the server does not have an address in the same > network as these IPs assigned […] Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/02b58eff_bb2dd3f8?usp=email : PS11, Line 4377: &o->push_ifconfig_ipv6_local)); > Maybe it would also be an idea to change > `multi_check_push_ifconfig_ipv6_extra_route()` to not be pa […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff Gerrit-Change-Number: 1192 Gerrit-PatchSet: 13 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Tue, 28 Oct 2025 13:55:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
