Attention is currently required from: d12fk, plaisthos.

flichtenheld has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email )

Change subject: wfp: add flag to allow DNS traffic to loopback
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File doc/man-sections/windows-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1541/comment/d5bb05f2_99eae1b5?usp=email :
PS1, Line 23:   Windows XP) to ignore said error. Note that pushing unknown 
options from
Can we maybe remove this Windows XP mention as a drive-by fix?


File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/1541/comment/c9ad5c85_76b9cf5a?usp=email :
PS1, Line 855:     if (msg->block_type >= 0 && msg->block_type < 
wfp_block_type_count)
I don't understand this conditional. So if block_type is between 0 and 
wfp_block_type_count, that is an error? Why?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f7237720b0892f5ba0caf60f941f9cc2241cdb6
Gerrit-Change-Number: 1541
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Wed, 04 Mar 2026 11:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to