Attention is currently required from: flichtenheld, plaisthos.

d12fk has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email )

Change subject: wfp: add flag to allow DNS traffic to loopback
......................................................................


Patch Set 4:

(2 comments)

File doc/man-sections/windows-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1541/comment/175adec9_5d09e09d?usp=email :
PS1, Line 23:   Windows XP) to ignore said error. Note that pushing unknown 
options from
> Feel free to put it in a separate patch *nudge*, *nudge*, *wink*, *wink* ;) 
> […]
Yeah, I think it's worth a dedicated patch. Will do.


File src/openvpn/wfp_block.h:

http://gerrit.openvpn.net/c/openvpn/+/1541/comment/113b6688_251db25a?usp=email :
PS4, Line 48:  * @param engine_handle On successful return contains the handle 
for a newly opened fwp
> Parameter names are wrong […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f7237720b0892f5ba0caf60f941f9cc2241cdb6
Gerrit-Change-Number: 1541
Gerrit-PatchSet: 4
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 05 Mar 2026 20:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: d12fk <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to