Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email )
Change subject: wfp: add flag to allow DNS traffic to loopback ...................................................................... Patch Set 4: Code-Review-1 (2 comments) File doc/man-sections/windows-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1541/comment/cdd6f755_709f8251?usp=email : PS1, Line 23: Windows XP) to ignore said error. Note that pushing unknown options from > Hm, I find the whole paragraph of limited use and would remove it rather > completely. […] Feel free to put it in a separate patch *nudge*, *nudge*, *wink*, *wink* ;) Either way, it is just a suggestion, it doesn't influence the merge of this patch. File src/openvpn/wfp_block.h: http://gerrit.openvpn.net/c/openvpn/+/1541/comment/2a9315b1_d4e0a1d9?usp=email : PS4, Line 48: * @param engine_handle On successful return contains the handle for a newly opened fwp Parameter names are wrong ``` wfp_block.h:48: warning: argument 'engine_handle' of command @param is not found in the argument list of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type) wfp_block.h:48: warning: argument 'index' of command @param is not found in the argument list of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type) wfp_block.h:48: warning: argument 'msg_handler' of command @param is not found in the argument list of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type) wfp_block.h:48: warning: The following parameters of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type) are not documented: parameter 'engine' parameter 'iface_index' parameter 'msg_handler_callback' ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1541?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0f7237720b0892f5ba0caf60f941f9cc2241cdb6 Gerrit-Change-Number: 1541 Gerrit-PatchSet: 4 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 11:08:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: d12fk <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
