Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email )
Change subject: Replace SHA256 with SIPHASH24 in HMAC cookie approach ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1827/comment/01bfb3d3_3b356a6a?usp=email : PS3, Line 3476: ASSERT(rand_bytes(c->c2.session_id_key, sizeof(c->c2.session_id_key))); I have to say that I don't particularly care for sprinkling that `ASSERT(rand_bytes())` all over the code. Might be better to have a `siphash_key_init` or something. It will not reduce the amount of code, but it will reduce the amount of duplicated semantics if you know what I mean. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3 Gerrit-Change-Number: 1827 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
