Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email )
Change subject: Replace SHA256 with SIPHASH24 in HMAC cookie approach ...................................................................... Patch Set 5: Code-Review-1 (1 comment) File tests/unit_tests/openvpn/test_pkt.c: http://gerrit.openvpn.net/c/openvpn/+/1827/comment/e84c4be3_665c03b1?usp=email : PS5, Line 522: rand_bytes(key, sizeof(key)); You missed one. As apparently did I in my last review since I flagged two and you fixed two. But there were three -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3 Gerrit-Change-Number: 1827 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 15:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
