Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email )

Change subject: Replace SHA256 with SIPHASH24 in HMAC cookie approach
......................................................................


Patch Set 4:

(2 comments)

File tests/unit_tests/openvpn/test_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1827/comment/e61393e2_992f11b5?usp=email :
PS4, Line 440:     rand_bytes(key, sizeof(key));
> should also use siphash_key_init?
Done


http://gerrit.openvpn.net/c/openvpn/+/1827/comment/d86fc94f_25937d66?usp=email :
PS4, Line 522:     rand_bytes(key, sizeof(key));
> should also use siphash_key_init?
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3
Gerrit-Change-Number: 1827
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 19:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to