Attention is currently required from: Arne Schwabe, Gianmarco De Gregori.

Răzvan Cojocaru has posted comments on this change by Gianmarco De Gregori. ( 
https://gerrit.openvpn.net/c/openvpn/+/2210?usp=email )

Change subject: socket: pause the listeners when accept() runs out of resources
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/openvpn/multi_io.c:

https://gerrit.openvpn.net/c/openvpn/+/2210/comment/9b995612_d1370825?usp=email 
:
PS1, Line 202:     if (delay && m->top.c2.timeval.tv_sec >= delay)
This breaks the mingw build (at least the cross-platform one on my Linux 
machine: `-Wconversion -Werror`).

`tv_sec` is `long` on Windows, `time_t` is 64-bit.

This needs a `(tv_sec_t)delay` cast, like `context_reschedule_sec()` does.



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2210?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I978041ea4e6323f5a92d8721809f0fa44b9c2e03
Gerrit-Change-Number: 2210
Gerrit-PatchSet: 1
Gerrit-Owner: Gianmarco De Gregori <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Gianmarco De Gregori <[email protected]>
Gerrit-Comment-Date: Tue, 17 Nov 2026 14:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to