Attention is currently required from: Arne Schwabe, Gert Doering, Răzvan 
Cojocaru.

Gianmarco De Gregori has posted comments on this change by Gianmarco De 
Gregori. ( https://gerrit.openvpn.net/c/openvpn/+/2210?usp=email )

Change subject: socket: pause the listeners when accept() runs out of resources
......................................................................


Patch Set 3:

(3 comments)

File src/openvpn/manage.c:

https://gerrit.openvpn.net/c/openvpn/+/2210/comment/faf50fa5_3231bd56?usp=email 
:
PS2, Line 3325:                 if (man_persist_state(persistent, paused ? 4 : 
1))
> what is this `4`? […]
Done


File src/openvpn/socket.c:

https://gerrit.openvpn.net/c/openvpn/+/2210/comment/83743194_9b5a2146?usp=email 
:
PS2, Line 434:     const bool out_of_resources = err == EMFILE || err == ENFILE 
|| err == ENOBUFS || err == ENOMEM;
> please sprinkle a few braces over this - there's too many operators for mere 
> mortals to grok this (` […]
Done


https://gerrit.openvpn.net/c/openvpn/+/2210/comment/15e1375a_8156730c?usp=email 
:
PS2, Line 438:         accept_resume = now + 1;
> can we add some logging here?  This will create spurious "connection refused" 
> on the client side - w […]
Done



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2210?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I978041ea4e6323f5a92d8721809f0fa44b9c2e03
Gerrit-Change-Number: 2210
Gerrit-PatchSet: 3
Gerrit-Owner: Gianmarco De Gregori <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Gert Doering <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Gert Doering <[email protected]>
Gerrit-Comment-Date: Wed, 18 Nov 2026 11:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gert Doering <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to