Attention is currently required from: Arne Schwabe, Gianmarco De Gregori.

Gert Doering has posted comments on this change by Gianmarco De Gregori. ( 
https://gerrit.openvpn.net/c/openvpn/+/2210?usp=email )

Change subject: socket: pause the listeners when accept() runs out of resources
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

File src/openvpn/manage.c:

https://gerrit.openvpn.net/c/openvpn/+/2210/comment/4cc79654_4f56a18f?usp=email 
:
PS2, Line 3325:                 if (man_persist_state(persistent, paused ? 4 : 
1))
what is this `4`?

I'm afraid this patch needs a bit of doxygen comment on top of 
`man_persist_state()` on what this is doing...


File src/openvpn/socket.c:

https://gerrit.openvpn.net/c/openvpn/+/2210/comment/bd369ef8_7e3abf98?usp=email 
:
PS2, Line 434:     const bool out_of_resources = err == EMFILE || err == ENFILE 
|| err == ENOBUFS || err == ENOMEM;
please sprinkle a few braces over this - there's too many operators for mere 
mortals to grok this (`out_of_resources = ( err == EMFILE || err == ENFILE 
...)`) or maybe just get rid of the temp variable and put it into the `if()` 
right away (having two `if()` with the #ifdef, not one with #ifdef nested into 
the condition)


https://gerrit.openvpn.net/c/openvpn/+/2210/comment/9d04688c_8537f519?usp=email 
:
PS2, Line 438:         accept_resume = now + 1;
can we add some logging here?  This will create spurious "connection refused" 
on the client side - which will show up in logs and will make people ask "what 
has happened here?".  Of course we do not want to log this once per second, so 
not fully trivial to get right.



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2210?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I978041ea4e6323f5a92d8721809f0fa44b9c2e03
Gerrit-Change-Number: 2210
Gerrit-PatchSet: 2
Gerrit-Owner: Gianmarco De Gregori <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Gert Doering <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Gianmarco De Gregori <[email protected]>
Gerrit-Comment-Date: Tue, 17 Nov 2026 15:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to