Hi,

On 22 January 2012 22:55, Przemek Rudy <[email protected]> wrote:
> Update for MMnet1000 board support for kernel 3.2.1 (svn r29742).

This patch does not apply for me:

jonas@shaker64:~/openwrt/root-git$ patch -p1 -i index.html.1
patching file linux/at91/MMnet1000/config-default
patching file linux/at91/MMnet1000/target.mk
patching file linux/at91/files/arch/arm/mach-at91/board-mmnet1000.c
patch: **** malformed patch at line 1944:  USA

Looks like your mailer line wrapped it.

Please split this patch into two patches (update to 3.2 and MMnet1000
support). Also when doing a kernel update please refresh the patches
(make target/linux/refresh), so they apply without any fuzz.

> Tested on MMnet1002 board version with Samsung NAND flash.
> Note it removes 600-usb_vbus_active_high.patch, that does not apply any
> more.

"Does not apply anymore" is not a very good reason ;). You should say
why it isn't needed anymore.

The tqma9263 subtarget still uses vbus_active_high, so you will
currently break compilation for this subtarget.

> Remember to set a valid machid in u-boot (or use my other previous patches).
>
> Signed-off-by: Przemek Rudy <[email protected]>
>
>
> ---
> Index: target/linux/at91/MMnet1000/config-default
> ===================================================================
> --- target/linux/at91/MMnet1000/config-default  (revision 0)
> +++ target/linux/at91/MMnet1000/config-default  (revision 0)
> @@ -0,0 +1,1901 @@
> +#
> +# Automatically generated file; DO NOT EDIT.
> +# Linux/arm 3.2.1 Kernel Configuration
> +#
> +CONFIG_ARM=y
> <snip>

Please do not put there a full kernel config, but only the differences
to the generic config for the target. This makes it easier to see what
is actually different (see the tqma9263 subtarget's config for an
example).

You will likely need to update the generic config for new common
symbols. You should try building one of the other at91 subtargets to
see if you caught all missing ones.


Regards
Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to