No hurry, I'm busy too :) Updating whole at91 would require someone else to test it on particular platform. Roughly it looks like only patches/* should be the subject to change, so shouldn't be much work. Anyway, I'll back to this in spare time.
BTW, u-boot update would be an option too at least for the proper handling of ubifs. Best, Przemek On 01/27/2012 02:25 PM, Jonas Gorski wrote: > Sorry for the late response. > > On Jan 23, 2012 4:48 PM, "Przemysław Rudy" <[email protected]> wrote: > >> >> On 23.01.2012 15:30, Jonas Gorski wrote: >>> [...] >>> This all belongs into a seperate patch and has nothing to do with >>> updating at91 to 3.2.1 (which you also do in this patch). >> ok, as 'original' MMnet1000 patch is not included in the tree my idea >> was to do it from scratch to replace the previous/base patch. >> If I get your point correctly, at first the previous patch should be >> applied, then the new one should include only updates since then. > > No, updated full patches are fine. The problem is if the patch has changes > that affect other targets/parts, like your update to 3.2.1. > >>> >>> Unless you mean this patch is supposed to update only MMnet1000 to >>> 3.2.1, then this patch clearly doesn't and implicitly updates most >>> other subtargets to 3.2.1, too. I don't think you will be able to just >>> have on subtarget on 3.2 and the others on 2.6.38, since the patches >>> won't apply to both. >> Yes, it does not seem to be possible without touching other targets. >> I propose an update to 3.2.1 (incremental from original patch) that will >> be put on hold on the mail list till other targets are ready. What about: >> - 1st patch - incremental (from old patch) that covers only kernel+config >> - 2nd patch - changes to current OpenWrt target allowing the 1st patch >> to be used (but will break other targets) >> >> Is that fine? > > Not quite. You should create two separate patches, one "generic" for > updating at91 to 3.2 (without breaking other subtargets), and one adding > MMnet1000 support. > > Whether you let the MMnet1000 support depend on the 3.2 patch being applied > or the other way round is up to you. > > Putting patches on hold won't work, by the time it should be applied it > likely doesn't apply anymore. You will need to regularly update and resend > your patches until they get applied. > > So please resubmit this patch split up into the two mentioned. > > Jonas > > > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
