Well, we could change it for ath79 and ramips right now, would be a simple rename without side effects.
We could use just SOC as proposed. I'd prefer to decide on the name right away and then would apply the patch directly without sending it to the list, to save us from rebasing... Best Adrian On 15 December 2019 18:11:05 CET, Daniel Golle <[email protected]> wrote: >On Sun, Dec 15, 2019 at 05:53:42PM +0100, [email protected] >wrote: >> Hi, >> >> how would you call the SOC variable in image Makefile then? (the >equivalent to ATH_SOC and MTK_SOC...) > >In a way those variables should be unified into something like 'SOC'... >For now, maybe 'LTQ_SOC' will do until we replace them all by 'SOC' and >that should be it... > >Cheers > >Daniel > >> >> Best >> >> Adrian >> >> > -----Original Message----- >> > From: openwrt-devel >[mailto:[email protected]] >> > On Behalf Of Hauke Mehrtens >> > Sent: Sonntag, 15. Dezember 2019 14:49 >> > To: Daniel Golle <[email protected]>; [email protected] >> > Cc: Martin Blumenstingl <[email protected]>; >openwrt- >> > [email protected] >> > Subject: Re: [OpenWrt-Devel] Lantiq DTS rename >> > >> > On 12/15/19 2:27 PM, Daniel Golle wrote: >> > > Hi Adrian, >> > > >> > > On Sun, Dec 15, 2019 at 02:10:14PM +0100, >[email protected] >> > wrote: >> > >> Hi, >> > >> >> > >> I consider doing a DTS rename for lantiq target similar to what >it's like on >> > ath79 and what I did for ramips earlier that year. >> > >> >> > >> However, I wonder whether the "soc_vendor_model.dts" scheme is >> > useful there, or whether it wouldn't be better to just use >> > "vendor_model.dts" ... >> > >> >> > >> Any thoughts on this or any NAK in general? >> > > >> > > soc_vendor_model should be appropriate here is well. why not? >> > >> > Yes please clean this up and use the soc_vendor_model model, I >think this is >> > the common format in the Linux kernel. >> > >> > Be aware that there is a pull request from Martin pending with some >changes >> > to the existing files: >> > https://github.com/openwrt/openwrt/pull/2216 >> > >> > Please also move the dts files into the lantiq subfolder at >> > arch/mips/boot/dts/lantiq/ >> > >> > Hauke
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
