Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Matthias Schiffer > Sent: Montag, 16. Dezember 2019 21:25 > To: Adrian Schmutzler <freif...@adrianschmutzler.de> > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] ramips: fix port setup for Ubiquiti > EdgeRouter X (and SFP) > > On 12/16/19 1:31 PM, Adrian Schmutzler wrote: > > The EdgeRouter only has LAN ports labelled eth0 to eth4 (plus > > unsupported eth5 for SFP version). Thus, there is no reason to set up > > one of them as WAN. > > > > This patch sets all ports to "lan" and removes the unused wan_mac. > > > > Actually, stock firmware on the EdgeRouter X assigns a specific MAC > > address to each port: > > > > eth0 *:f4 (label) > > eth1 *:f5 > > eth2 *:f6 > > eth3 *:f7 > > eth4 *:f8 > > switch0 *:f9 > > > > (No data for SFP version) > > > > Only the label MAC is stored on flash in factory 0x22. > > > > OpenWrt currently sets ðernet to this address, so all ports will > > use that one in OpenWrt. > > > > Signed-off-by: Adrian Schmutzler <freif...@adrianschmutzler.de> > > Having a WAN port by default is extremely useful (and necessary for easy > automatic configuration by OpenWrt-based frameworks like Gluon without > having to special-case many devices). > > I would prefer if we could always make one port WAN as long as we have at > least two independently configurable ports, regardless of labeling - at least > that was my policy for creating new hardware support in the past. > > Regards, > Matthias
I received feedback from two people about this, and both were against merging this. So I will not merge it and mark the patch as rejected. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel