On 2021-01-11 14:38, Stijn Segers wrote:
Hi Alberto,
Alberto Bursi <[email protected]> schreef op 11 januari 2021
03:56:23 CET:
On 10/01/21 22:50, Stijn Segers wrote:
Hi Sven,
Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer
<[email protected]>:
Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers:
> @@ -228,6 +229,7 @@ do_save_conffiles() {
>
> if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then
> echo "${INSTALLED_PACKAGES}" >> "$CONFFILES"
> + echo "${SERVICE_STATUS}" >> "$CONFFILES"
> mkdir -p "$ETCBACKUP_DIR"
Am I reading this correctly and is this only keeping track of
service
status if you tell sysupgrade to save packages? What's the
rationale
behind that?
I have a personal build with all packages preinstalled, so I don't
need
that. Would like to keep track of service status though. Can those
two
things be entangled?
Stijn,
my intention was to not change the current behavior by default, so
an
extra
switch or extending an existing switch looked like the way. I've
choosen the
lazy one, based on "when the user is storing the packages-list, he
is
for sure
interested in the services".
But I'm happy to add a separate switch to sysupgrade. Any preference
of the
letter? What about using "-s"?
Sven
Yes, that's still free and the most intuitive I think.
Thanks!
Stijn
Since we (me, Andre Heider and Paul Spooren) are discussing/asking
about
enabling this by default, do you have any opinion on that?
-Alberto
That would be great, as Adrian pointed out it's something you'd expect
would be saved when you tell sysupgrade to keep settings.
So +1 from me on making it default. All my AP/testing devices now have
scripting to disable e.g. DHCP and DNS again after an upgrade.
Stijn
I am also in favor of saving the service status by default.
This is the expected behavior as long as you don't use the '-n' switch.
Currently we use our own patchset for this, but I would prefer to get
an upstream solution.
Martin
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
