Hi everybody, My take on this is that build issues can happen, but then they should be fixed within a day or two. I do hope we can mandate building of PR's prior to merging on the new virtual build server soon though. If we know in advance that a PR is going to break building due to other pending PR's, then they should all be ready for merging at the same time.
In this case I guess it is an oversight, as the actual breaking was probably caused by merging this one: https://github.com/OPM/opm-parser/pull/249 before propagating #608 to all modules. Andreas, will you propagate #608 to the other modules? Kristian, thanks for catching this one. Cheers, Alf ________________________________________ From: Opm [opm-boun...@opm-project.org] on behalf of Kristian Flikka [kf...@statoil.com] Sent: Wednesday, July 02, 2014 8:16 AM To: opm@opm-project.org Subject: [OPM] Build system updates Hi People of OPM! Currently - we have a situation where four OPM projects doesn't build (see http://80.240.129.131:8080/view/OPM%20sibling/) , due to this PR: https://github.com/OPM/opm-core/pull/608, and the lack of synchronization across other projects (as I understand it). I have some slight problems with this, one of them being that we in our team have a "dashboard" in our team room where build statuses are shown. Now - it lights up like a Christmas tree, and normally that should "call for attention" - something is wrong and must be fixed! My question is, what is the policy for introducing these kinds of changes, that one knows will break other builds? My suggestion is that we agree on having "lined up" PR's for all projects, before merging one of them, and that the responsibility of _making sure_ this is done (not doing it) lies on the person introducing the change? Kristian ------------------------------------------------------------------- The information contained in this message may be CONFIDENTIAL and is intended for the addressee only. Any unauthorised use, dissemination of the information or copying of this message is prohibited. If you are not the addressee, please notify the sender immediately by return e-mail and delete this message. Thank you _______________________________________________ Opm mailing list Opm@opm-project.org http://www.opm-project.org/mailman/listinfo/opm ------------------------------------------------------------------- The information contained in this message may be CONFIDENTIAL and is intended for the addressee only. Any unauthorised use, dissemination of the information or copying of this message is prohibited. If you are not the addressee, please notify the sender immediately by return e-mail and delete this message. Thank you _______________________________________________ Opm mailing list Opm@opm-project.org http://www.opm-project.org/mailman/listinfo/opm
