Yeah, Intelij was acting up... changed settings and removed all whitespace changes from PR.
Thank you, Kal Cramer On Monday, October 1, 2018 at 11:10:16 PM UTC-7, Grzegorz Grzybek wrote: > > Hello Kal > > I see your PR contains lots of extra changes that do not do anything (like > changing tabs to spaces, etc.) While reformatting code is not a bad thing, > I'd like not to mix such changes with "real" changes. It hurts (how I call > it) "cherrypickability" badly... > > Also, changing exported Interfaces require bumping at least minor (2nd) > digit in version number according to semantic versioning. Please review > https://github.com/ops4j/org.ops4j.pax.web/pull/215/files and remove all > the changes that are format-related only. > > best regards > Grzegorz Grzybek > > pon., 1 paź 2018 o 18:12 <[email protected] <javascript:>> napisał(a): > >> Link to task, let me know if design is acceptable: >> https://ops4j1.jira.com/browse/PAXWEB-1180 >> >> On Sunday, September 30, 2018 at 4:26:12 AM UTC-7, Achim Nierbeck wrote: >>> >>> Done. >>> >>> Am Sa., 29. Sep. 2018 um 12:12 Uhr schrieb Grzegorz Grzybek < >>> [email protected]>: >>> >>>> Hello >>>> >>>> Achim - I don't think I can add people to groups in PAXWEB - could you >>>> please look at it? Or add Kal Cramer to relevant groups? >>>> >>>> Kal - yes - the configuration was designed that factory PID is per >>>> bundle, i.e. 1:1 factoryPid : symbolic name. That was all that was >>>> anticipated initially. If you have idea to enhance this configuration, I'd >>>> be happy to review your PR. >>>> >>>> Thanks and best regards >>>> Grzegorz Grzybek >>>> >>>> pt., 28 wrz 2018 o 23:37 <[email protected]> napisał(a): >>>> >>>>> I'll plan on making the necessary changes in a fork and create a PR if >>>>> this seems reasonable. If I can get added to the JIRA I can create the >>>>> ticket and such. >>>>> >>>>> -Kal Cramer >>>>> >>>>> On Wednesday, September 26, 2018 at 10:32:08 AM UTC-7, >>>>> [email protected] wrote: >>>>>> >>>>>> Hello! >>>>>> >>>>>> Based on what I see in: >>>>>> >>>>>> https://ops4j1.jira.com/wiki/spaces/paxweb/pages/354025473/HTTP+Context+processing >>>>>> >>>>>> >>>>>> The authMethod and realmName must be defined on a per bundle basis >>>>>> within the corresponding web.xml. I was wondering if there's a >>>>>> configuration that's possible right now to define a default it for all >>>>>> bundles? >>>>>> >>>>>> I would like to configure this for all existing and new bundles that >>>>>> are added to my project. >>>>>> >>>>>> Thank you in advance, >>>>>> Kal Cramer >>>>>> >>>>> -- >>>>> -- >>>>> ------------------ >>>>> OPS4J - http://www.ops4j.org - [email protected] >>>>> >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "OPS4J" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>> >>> -- >>> >>> Apache Member >>> Apache Karaf <http://karaf.apache.org/> Committer & PMC >>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer >>> & Project Lead >>> blog <http://notizblog.nierbeck.de/> >>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >>> >>> Software Architect / Project Manager / Scrum Master >>> >>> -- >> -- >> ------------------ >> OPS4J - http://www.ops4j.org - [email protected] <javascript:> >> >> --- >> You received this message because you are subscribed to the Google Groups >> "OPS4J" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
