Hello Kal, I tried cherry-picking your change to pax-web-7.2.x branch, but as I expected:
[INFO] --- maven-bundle-plugin:3.3.0:baseline (baseline) @ pax-web-spi --- [INFO] Baseline Report - Generated by Apache Felix Maven Bundle Plugin on 2018-10-12T08:34Z based on Bnd - see http://www.aqute.biz/Bnd/Bnd [INFO] Comparing bundle pax-web-spi version 7.2.4-SNAPSHOT to version 7.1.0 [INFO] [INFO] PACKAGE_NAME DELTA CUR_VER BASE_VER REC_VER WARNINGS [INFO] = ================================================== ========== ========== ========== ========== ========== [INFO] * org.ops4j.pax.web.service.spi major 7.2.4.SNAPSHOT 7.1.0 *8.0.0 Version increase required* [INFO] > interface org.ops4j.pax.web.service.spi.Configuration [INFO] + method getDefaultAuthMethod() [INFO] + access abstract [INFO] + return java.lang.String [INFO] + method getDefaultRealmName() [INFO] + access abstract [INFO] + return java.lang.String 8.0.0 is good version to add these methods. I know that semantic versioning adds some constraints, but there's a reason... We have to be realistic here - this "protection" is for those who implement this interface - if they rely on 7.x version, they should not be forced to implement additional methods. I had similar problem with https://ops4j1.jira.com/browse/PAXWEB-1167 where I needed new methods on org.ops4j.pax.web.service.spi.ServerController interface. I added these methods in 8.0.0 (master branch), but for 7.2.0 I instead created new org.ops4j.pax.web.service.spi.ServerControllerEx interface and changed: org.ops4j.pax.web.service.spi.ServerControllerEx to: class ServerControllerImpl implements ServerController, ServerControllerEx And new methods went to ServerControllerEx. Then in some implementation (internal) class I just used: if (serverController instanceof ServerControllerEx) { ((ServerControllerEx)serverController).removeSecurityConstraintMapping(model); } To be honest, in OSGi semantic versioning is even strictier - because it's not only about interfaces, but entire packages! And here's where I had to be clever/realistic. The "baseline" (a version used by maven-bundle-plugin:baseline which does the semantic versioning checks) in 7.2.x branch is set to ... 7.1.0 (which is against OSGi purists). But that's where I had to be realistic... May I ask you to rewrite your PR for 7.2.x with my suggested changes? (create ConfigurationEx interface with your new methods). best regards Grzegorz Grzybek czw., 11 paź 2018 o 15:57 Grzegorz Grzybek <[email protected]> napisał(a): > Hello Kal - I should have time to look at it tomorrow. > > best regards > Grzegorz Grzybek > > pon., 8 paź 2018 o 17:21 <[email protected]> napisał(a): > >> Hello, >> >> Sorry for the delayed response. Based on my understanding of semantic >> versioning I would want a minor release that includes my interface changes. >> Let me know if that's possible, the ticket should be updated to 7.3.0 if >> so. My bad for updating this field. I understand that it was incorrect now. >> >> Thank you for your time, >> Kal Cramer >> >> >> On Thursday, October 4, 2018 at 10:57:01 PM UTC-7, Grzegorz Grzybek wrote: >>> >>> Hello >>> >>> I see https://github.com/ops4j/org.ops4j.pax.web/pull/215 is already >>> merged to master, which didn't have any release yet. However >>> https://ops4j1.jira.com/browse/PAXWEB-1180 is set to be fixed in 7.2.3. >>> >>> Kal - what's the version you want to have released? >>> >>> regards >>> Grzegorz Grzybek >>> >>> pt., 5 paź 2018 o 06:12 Grzegorz Grzybek <[email protected]> >>> napisał(a): >>> >>>> Hello >>>> >>>> What version (branch) do you want to get released? I'll review your PR >>>> again - the only problem I see is that changed interfaces will require >>>> bumping not micro (3rd), but minor (2nd) digit in the version. Maybe >>>> there's a way to have this implemented without adding new interface >>>> methods? >>>> >>>> regards >>>> Grzegorz Grzybek >>>> >>>> czw., 4 paź 2018 o 21:24 <[email protected]> napisał(a): >>>> >>>>> I mentioned this on my PR but also wanted to mention here if it was >>>>> missed. >>>>> >>>>> When is the next pax web release planned for? If it can happen so we >>>>> don't have to keep our own fork release I'd appreciate it. >>>>> >>>>> Thank you, >>>>> Kal Cramer >>>>> >>>>> >>>>> On Tuesday, October 2, 2018 at 8:07:32 AM UTC-7, [email protected] >>>>> wrote: >>>>>> >>>>>> Yeah, Intelij was acting up... changed settings and removed all >>>>>> whitespace changes from PR. >>>>>> >>>>>> Thank you, >>>>>> Kal Cramer >>>>>> >>>>>> On Monday, October 1, 2018 at 11:10:16 PM UTC-7, Grzegorz Grzybek >>>>>> wrote: >>>>>>> >>>>>>> Hello Kal >>>>>>> >>>>>>> I see your PR contains lots of extra changes that do not do anything >>>>>>> (like changing tabs to spaces, etc.) While reformatting code is not a >>>>>>> bad >>>>>>> thing, I'd like not to mix such changes with "real" changes. It hurts >>>>>>> (how >>>>>>> I call it) "cherrypickability" badly... >>>>>>> >>>>>>> Also, changing exported Interfaces require bumping at least minor >>>>>>> (2nd) digit in version number according to semantic versioning. Please >>>>>>> review https://github.com/ops4j/org.ops4j.pax.web/pull/215/files >>>>>>> and remove all the changes that are format-related only. >>>>>>> >>>>>>> best regards >>>>>>> Grzegorz Grzybek >>>>>>> >>>>>>> pon., 1 paź 2018 o 18:12 <[email protected]> napisał(a): >>>>>>> >>>>>>>> Link to task, let me know if design is acceptable: >>>>>>>> https://ops4j1.jira.com/browse/PAXWEB-1180 >>>>>>>> >>>>>>>> On Sunday, September 30, 2018 at 4:26:12 AM UTC-7, Achim Nierbeck >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Done. >>>>>>>>> >>>>>>>>> Am Sa., 29. Sep. 2018 um 12:12 Uhr schrieb Grzegorz Grzybek < >>>>>>>>> [email protected]>: >>>>>>>>> >>>>>>>>>> Hello >>>>>>>>>> >>>>>>>>>> Achim - I don't think I can add people to groups in PAXWEB - >>>>>>>>>> could you please look at it? Or add Kal Cramer to relevant groups? >>>>>>>>>> >>>>>>>>>> Kal - yes - the configuration was designed that factory PID is >>>>>>>>>> per bundle, i.e. 1:1 factoryPid : symbolic name. That was all that >>>>>>>>>> was >>>>>>>>>> anticipated initially. If you have idea to enhance this >>>>>>>>>> configuration, I'd >>>>>>>>>> be happy to review your PR. >>>>>>>>>> >>>>>>>>>> Thanks and best regards >>>>>>>>>> Grzegorz Grzybek >>>>>>>>>> >>>>>>>>>> pt., 28 wrz 2018 o 23:37 <[email protected]> napisał(a): >>>>>>>>>> >>>>>>>>>>> I'll plan on making the necessary changes in a fork and create a >>>>>>>>>>> PR if this seems reasonable. If I can get added to the JIRA I can >>>>>>>>>>> create >>>>>>>>>>> the ticket and such. >>>>>>>>>>> >>>>>>>>>>> -Kal Cramer >>>>>>>>>>> >>>>>>>>>>> On Wednesday, September 26, 2018 at 10:32:08 AM UTC-7, >>>>>>>>>>> [email protected] wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hello! >>>>>>>>>>>> >>>>>>>>>>>> Based on what I see in: >>>>>>>>>>>> >>>>>>>>>>>> https://ops4j1.jira.com/wiki/spaces/paxweb/pages/354025473/HTTP+Context+processing >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> The authMethod and realmName must be defined on a per bundle >>>>>>>>>>>> basis within the corresponding web.xml. I was wondering if there's >>>>>>>>>>>> a >>>>>>>>>>>> configuration that's possible right now to define a default it for >>>>>>>>>>>> all >>>>>>>>>>>> bundles? >>>>>>>>>>>> >>>>>>>>>>>> I would like to configure this for all existing and new bundles >>>>>>>>>>>> that are added to my project. >>>>>>>>>>>> >>>>>>>>>>>> Thank you in advance, >>>>>>>>>>>> Kal Cramer >>>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> -- >>>>>>>>>>> ------------------ >>>>>>>>>>> OPS4J - http://www.ops4j.org - [email protected] >>>>>>>>>>> >>>>>>>>>>> --- >>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>> Google Groups "OPS4J" group. >>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Apache Member >>>>>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC >>>>>>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> >>>>>>>>> Committer & Project Lead >>>>>>>>> blog <http://notizblog.nierbeck.de/> >>>>>>>>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >>>>>>>>> >>>>>>>>> Software Architect / Project Manager / Scrum Master >>>>>>>>> >>>>>>>>> -- >>>>>>>> -- >>>>>>>> ------------------ >>>>>>>> OPS4J - http://www.ops4j.org - [email protected] >>>>>>>> >>>>>>>> --- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "OPS4J" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to [email protected]. >>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>> >>>>>>> -- >>>>> -- >>>>> ------------------ >>>>> OPS4J - http://www.ops4j.org - [email protected] >>>>> >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "OPS4J" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >> -- >> ------------------ >> OPS4J - http://www.ops4j.org - [email protected] >> >> --- >> You received this message because you are subscribed to the Google Groups >> "OPS4J" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
