I'm not totally sure whether this will be able to go into pax-web-7.2.x or a pax-web-7.3.x will have to be made, but I'll try to do the former. PR here: https://github.com/ops4j/org.ops4j.pax.web/pull/217
Thank you! Kal Cramer On Monday, October 15, 2018 at 10:51:30 PM UTC-7, Grzegorz Grzybek wrote: > > Hello Kal > > For "master" branch it's fine - I've merged this. Can you now create PR > for the version you like? e.g., pax-web-7.2.x? > > best regards > Grzegorz Grzybek > > pon., 15 paź 2018 o 18:20 <[email protected] <javascript:>> napisał(a): > >> Created the following PR with the update to make the interface methods >> default: >> https://github.com/ops4j/org.ops4j.pax.web/pull/216 >> >> I can merge myself after CI passes, thank you for the suggestion! >> Kal Cramer >> >> On Friday, October 12, 2018 at 12:48:09 AM UTC-7, laeubi wrote: >>> >>> It could return null and code must be aware of this (what would be the >>> same with a dedicated interface), the API of that method should only >>> state that: >>> >>> a) the default implementation will be removed on next major release >>> b) it can return null and what happens then >>> c) if it will be ok to return null in the next major release >>> >>> Am 12.10.18 um 09:11 schrieb Grzegorz Grzybek: >>> > >>> > >>> > pt., 12 paź 2018 o 08:56 'Christoph Läubrich' via OPS4J >>> > <[email protected] <mailto:[email protected]>> napisał(a): >>> > >>> > Just wondering if it is okay for BND if the interface has a (Java >>> 8) >>> > default implementation (if this is possible), that should be >>> compatible >>> > with previous release. >>> > >>> > >>> > Hmm, good idea - I didn't think about it. But what the default method >>> > could return - probably null... >>> > >>> > ~Grzegorz >>> >> -- >> -- >> ------------------ >> OPS4J - http://www.ops4j.org - [email protected] <javascript:> >> >> --- >> You received this message because you are subscribed to the Google Groups >> "OPS4J" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
