Hi Erich: I plan to check in my changes today (along with other changes mentioned in the other email). Did you want me to hold off until you have reviewed them?
I will let you do the tagging when it is ready. Thanks, Bernard On 1/29/07, Erich Focht <[EMAIL PROTECTED]> wrote: > Hi Bernard, > > I'll try to have a look this week, hope to find time. Need to catch up with > the changes. Please leave the tagging to me right now. > > We're currently not before a release, therefore let me see whether > systeminstaller needs a refurbishment, it would be good timing to do it. > > regards, > Erich > > On Sunday 28 January 2007 23:02, Bernard Li wrote: > > My patch is against systeminstaller-oscar trunk, so if you can confirm > > that it works fine under Debian, I will tag it if nobody else objects > > -- Erich? > > > > Thanks, > > > > Bernard > > > > On 1/28/07, Geoffroy VALLEE <[EMAIL PROTECTED]> wrote: > > > Hi Bernard, > > > > > > Please if you really want to tag 2.3.2, contact me because we have to be > > > sure > > > it works on Debian. Unfortunately, i will not have the time to check that > > > point within the new few days. > > > FYI, systeminstaller-oscar trunk already includes modifications for > > > Debian. > > > > > > Thanks, > > > > > > On Sunday 28 January 2007 06:42, Bernard Li wrote: > > > > Hi guys: > > > > > > > > Attached please see the patch I plan to check in for SystemInstaller. > > > > > > > > I cleaned up the code such that the target "make rpm" works correctly. > > > > I used the following step to successfully build the RPMs under > > > > fc6-i386 from SVN source: > > > > > > > > # perl Makefile.PL > > > > # make manifest > > > > # make rpm > > > > > > > > The MANIFEST file should not be checked in - it should be generated by > > > > running 'make manifest'. However, it does seems that MANIFEST = > > > > MANIFEST.stub, so perhaps we should just check it in, in that case we > > > > should probably update the docs and remove the .stub file. I am > > > > indifferent to this particular issue. > > > > > > > > I believe with the changes, you only need to update the version in > > > > Makefile.PL and the spec file's version will also be updated. > > > > > > > > The patch also fixes the following bug: > > > > > > > > http://svn.oscar.openclustergroup.org/trac/oscar/ticket/260 > > > > > > > > Does anybody else plan to make modifications to systeminstaller-oscar? > > > > If not, then I will tag 2.3.2 and check it into OSCAR trunk. > > > > > > > > Comments? > > > > > > > > Thanks, > > > > > > > > Bernard > > > > > > -- > > > Geoff > > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Oscar-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oscar-devel
