Hi Erich:

On 1/30/07, Erich Focht <[EMAIL PROTECTED]> wrote:

> The problem is that the version info needs to be in the .spec file, otherwise
> build_rpms will not be able to build an RPM out of a directory. If "make
> srpm" would work (never tried), I could change build_rpms accordingly. As
> said, need to think about a concept which doesn't break Debian.

I tested the 'make srpm' target, and it correctly built a SRPM.  I
check the spec file as well and the version information is correctly
set.  Finally I can build the RPMs successfully from the SRPM.

> > > You also had some change in the IA.pm file. Please explain that. What is 
> > > it
> > > supposed to fix?
> >
> > http://svn.oscar.openclustergroup.org/trac/oscar/ticket/260
> >
> > The patch will generate a compatible autoinstallscript.conf which will
> > allow the new version of SystemImager to mark a partition as
> > linux-swap correctly.
>
> After a quick look I somewhat doubt that your patch treats software raids
> correctly (i.e. the case where swap is on a software raid). It's late, I
> should have a closer look tomorrow.

All the patch does is to generate an autoinstallscript.conf for
SystemImager such that it can generate a correct .master script which
will mark the swap partition as "linux-swap".  If you decide to raid
your swap, both partitions should still be marked as "linux-swap", so
I don't think this is an issue?

In the .master script, instead of how it was before (described in the
bug where the swap partition is marked incorrectly):

logmsg "parted -s -- $DISK0 mkpart logical $START_MB $END_MB || shellout"

it will be:

logmsg "parted -s -- $DISK0 mkpart logical linux-swap $START_MB
$END_MB || shellout"

Anyways, I think Andrea can confirm whether my patch will work or not...

> > That's great - but is it okay for me to check in intermediate RPMs for
> > systeminstaller-oscar as Geoffroy suggested such that my patch can be
> > tested?
>
> From my side, yes, no problem.

Great, thanks!

Cheers,

Bernard

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Oscar-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oscar-devel

Reply via email to