Hi Robert,
> Hi Jim,
>
> The submission as it stands look like it'll break the build when using
> the Sgi Inventor, and only build when using Coin. The VRMLnodes code
> looks to me like something you be kept within the #if __COIN__ blocks.
OK, I'll make that change.
>
> There is also a "false &&" added to following code:
>
> // Set lighting
> if (false && action->getLightModel() ==
> SoLightModel::BASE_COLOR) {
> stateSet->setMode(GL_LIGHTING, osg::StateAttribute::OFF);
> }
>
> Which nullifies this whole check. It kinda looks like a temporary
> debugging hack to me. Is this really indended? If so then the whole
> block should be #if'd out or removed completely. I can't help feel
> that the other possibility is that you are just hacking the plugin to
> behave how you want it to, while others have needed it to behave
> differently so this code will break others models.
That was a temporary debugging hack, which I should have taken out
before submitting it.
> I also feel that always adding the LightGroup into the root node is
> something that should only do if you have something to add into this
> group, and you don't know whether you do till the scene is parsed and
> created. This LightGroup really should only be created when needed.
If I change the code to create the LightGroup and add it to the scene
when the first light is encounterd, would that be acceptable to you?
>
> Before I merge any of these changes I need clarification on the above
> items, and we also need to fix the problems.
>
Jim.
> Thanks,
> Robert.
>
> On Wed, Oct 22, 2008 at 3:11 PM, Jim Vaughan <[EMAIL PROTECTED]> wrote:
> >
> >
> > Hi Robert,
> >
> > Here the changes discussed in -users
> >
> > Cheers,
> > Jim
> >
> >> -----Original Message-----
> >> From: [EMAIL PROTECTED]
> >> [mailto:[EMAIL PROTECTED] On Behalf
> >> Of Robert Osfield
> >> Sent: Wednesday, October 22, 2008 1:25 AM
> >> To: OpenSceneGraph Users
> >> Subject: Re: [osg-users] Changes to Inventor loader
> >>
> >> Hi Jim,
> >>
> >> Yes, just post the changed files to osg-submissions, I'll
> pick them up
> >> from there and review & merge them in suitable or get back
> to you with
> >> suggested changes. osg-submissions is the route to use as
> it's a low
> >> volume list that is dedicated to just submissions, osg-users is for
> >> general support and is high volume so patches can easily
> get lost or
> >> missed.
> >>
> >> Cheers,
> >> Robert.
> >>
> >> On Wed, Oct 22, 2008 at 7:52 AM, Jim Vaughan
> <[EMAIL PROTECTED]> wrote:
> >> >
> >> > Hi Everyone,
> >> >
> >> > I've made a few changes to the Inventor loader, which I'd
> >> like to offer back to the community:
> >> >
> >> > - Matrix transform nodes were stripped out, and the
> >> vertices and normals of each node were
> >> > transposed by the modelling matrix. My change preserves
> >> the matrix transform nodes, so that
> >> > models can still be articulated by changing the matrices.
> >> >
> >> > - Lights were copied from the COIN scenegraph to the OSG
> >> scenegraph, but they were not associated
> >> > with a LightSource node. My change for this creates a
> >> Group and adds a LightSource for each Light.
> >> >
> >> > - If VRML textures have names, the name is now copied to
> >> the OSG scenegraph.
> >> >
> >> > Should I send the affected files to osg-submissions?
> >> >
> >> > Thanks!
> >> > Jim
> >> > _______________________________________________
> >> > osg-users mailing list
> >> > [EMAIL PROTECTED]
> >> >
> >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-opensce
> >> negraph.org
> >> >
> >> _______________________________________________
> >> osg-users mailing list
> >> [EMAIL PROTECTED]
> >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-opensce
> >> negraph.org
> >>
> >>
> >> Hi Robert,
> >>
> >> Here they are,
> >>
> >> Cheers,
> >> Jim
> >>
> >> > -----Original Message-----
> >> > From: [EMAIL PROTECTED]
> >> > [mailto:[EMAIL PROTECTED] On Behalf
> >> > Of Robert Osfield
> >> > Sent: Wednesday, October 22, 2008 1:25 AM
> >> > To: OpenSceneGraph Users
> >> > Subject: Re: [osg-users] Changes to Inventor loader
> >> >
> >> > Hi Jim,
> >> >
> >> > Yes, just post the changed files to osg-submissions, I'll
> >> pick them up
> >> > from there and review & merge them in suitable or get back
> >> to you with
> >> > suggested changes. osg-submissions is the route to use as
> >> it's a low
> >> > volume list that is dedicated to just submissions,
> osg-users is for
> >> > general support and is high volume so patches can easily
> get lost or
> >> > missed.
> >> >
> >> > Cheers,
> >> > Robert.
> >> >
> >> > On Wed, Oct 22, 2008 at 7:52 AM, Jim Vaughan
> <[EMAIL PROTECTED]> wrote:
> >> > >
> >> > > Hi Everyone,
> >> > >
> >> > > I've made a few changes to the Inventor loader, which I'd
> >> > like to offer back to the community:
> >> > >
> >> > > - Matrix transform nodes were stripped out, and the
> >> > vertices and normals of each node were
> >> > > transposed by the modelling matrix. My change preserves
> >> > the matrix transform nodes, so that
> >> > > models can still be articulated by changing the matrices.
> >> > >
> >> > > - Lights were copied from the COIN scenegraph to the OSG
> >> > scenegraph, but they were not associated
> >> > > with a LightSource node. My change for this creates a
> >> > Group and adds a LightSource for each Light.
> >> > >
> >> > > - If VRML textures have names, the name is now copied to
> >> > the OSG scenegraph.
> >> > >
> >> > > Should I send the affected files to osg-submissions?
> >> > >
> >> > > Thanks!
> >> > > Jim
> >> > > _______________________________________________
> >> > > osg-users mailing list
> >> > > [EMAIL PROTECTED]
> >> > >
> >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-opensce
> >> > negraph.org
> >> > >
> >> > _______________________________________________
> >> > osg-users mailing list
> >> > [EMAIL PROTECTED]
> >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-opensce
> >> > negraph.org
> >> >
> >
> > _______________________________________________
> > osg-submissions mailing list
> > [email protected]
> >
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-o
> penscenegraph.org
> >
> >
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-o
> penscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
