Thanks Jim, the changes looked better. They wouldn't quite compile on my Linux box so I've changed a bit of SbString/SbName usage to std::string, fixed the case of the one of the includes (I guess you work under Windows) and removed the "this->" usage in the constructor as it's superfluous and confusing.
On Sat, Oct 25, 2008 at 8:42 AM, Jim Vaughan <[EMAIL PROTECTED]> wrote: > > Hi Robert, > > I've made the changes we discussed and tested as much as > I can in my environment. Please let me know if you find > any other issues. > > Cheers, > Jim. > >> -----Original Message----- >> From: [EMAIL PROTECTED] >> [mailto:[EMAIL PROTECTED] On >> Behalf Of Robert Osfield >> Sent: Friday, October 24, 2008 9:39 AM >> To: OpenSceneGraph Submissions >> Subject: Re: [osg-submissions] Changes to Inventor loader >> >> Hi Jim, >> >> On Fri, Oct 24, 2008 at 4:32 PM, Jim Vaughan <[EMAIL PROTECTED]> wrote: >> > >> > OK, I'll make that change. >> >> Thanks. >> >> > That was a temporary debugging hack, which I should have taken out >> > before submitting it. >> >> Peer review does work :-) >> >> >> I also feel that always adding the LightGroup into the root node is >> >> something that should only do if you have something to add >> into this >> >> group, and you don't know whether you do till the scene is >> parsed and >> >> created. This LightGroup really should only be created >> when needed. >> > >> > If I change the code to create the LightGroup and add it to >> the scene >> > when the first light is encounterd, would that be acceptable to you? >> >> Just this is how I was thinking the code should work. Something like >> leave the light group pointer null and create it on demand and add it >> into the scene graph, then reuse this group thereafter. >> >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-o >> penscenegraph.org >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
