Hi Simon, I'm not happy with making another very commonly called inline method virtual as it will the performance implications are not trivial. The methods are deliberately made inline to keep the performance overhead to a minimum. For this reason I won't be merging this change.
Robert. On Fri, Nov 21, 2008 at 12:10 PM, Simon Hammett <[EMAIL PROTECTED]> wrote: > Hi Robert, > > Please find attached a modified version of osg/NodeVisitor from trunk. > The specific changes are to make virtual both: > void pushOntoNodePath(Node* node) > void popFromNodePath() > > The use case for this is to allow derived node visitors to be informed when > the level in the graph changes so they can push & pop their own internal > state. > > Otherwise there is no good way of knowing that this has happened. > I could possibly do something where I try and store a previous parent > node pointer > and check that within the accept methods but that's butt ugly. > > -- > The truth is out there. Usually in header files. > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
